Skip to content

Conversation

@nikatza
Copy link
Contributor

@nikatza nikatza commented Jul 11, 2025

Following limitations apply to the current implementation:

  • only ISIS (no OSPF)
  • only one IGP process per device

@nikatza nikatza changed the title rfc: Add IGP resource, controller, and cisco nxos provider rfc: add IGP resource, controller, and cisco nxos provider Jul 11, 2025
@felix-kaestner felix-kaestner changed the base branch from main to rfc/device July 11, 2025 13:12
@hardikdr hardikdr added this to Roadmap Jul 12, 2025
@felix-kaestner felix-kaestner force-pushed the rfc/device branch 2 times, most recently from 16f2bac to 17f847b Compare July 14, 2025 18:11
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Jul 15, 2025
@felix-kaestner
Copy link
Contributor

@nikatza Could you have a look at the failing pipelines and rebase this PR? 🙏

@nikatza
Copy link
Contributor Author

nikatza commented Jul 16, 2025

@nikatza Could you have a look at the failing pipelines and rebase this PR? 🙏

Done. This PR is still WIP

@nikatza nikatza force-pushed the feat-add-igp branch 2 times, most recently from 3895c94 to 96a320a Compare July 16, 2025 22:44
@nikatza nikatza force-pushed the feat-add-igp branch 6 times, most recently from 6207a3b to 88fe06e Compare July 18, 2025 11:49
@felix-kaestner felix-kaestner force-pushed the rfc/device branch 6 times, most recently from 946e79a to 1364ace Compare July 21, 2025 11:27
@nikatza nikatza marked this pull request as ready for review July 22, 2025 13:25
@nikatza nikatza requested review from a team as code owners July 22, 2025 13:25
@nikatza nikatza force-pushed the feat-add-igp branch 2 times, most recently from 15d9158 to 271fd37 Compare July 22, 2025 16:26
@nikatza nikatza force-pushed the feat-add-igp branch 2 times, most recently from 49b6b99 to 442cc55 Compare July 23, 2025 14:04
@nikatza nikatza force-pushed the feat-add-igp branch 4 times, most recently from 8ae35e2 to 1ac3b8c Compare August 5, 2025 07:29
Base automatically changed from rfc/device to main August 6, 2025 11:25
@felix-kaestner felix-kaestner requested a review from a team as a code owner August 6, 2025 11:25
@nikatza nikatza force-pushed the feat-add-igp branch 2 times, most recently from 0f1fbd7 to 16da247 Compare August 15, 2025 14:29
@nikatza nikatza changed the title rfc: add IGP resource, controller, and cisco nxos provider cisco-nxos-provider: configure ISIS Aug 15, 2025
@nikatza nikatza changed the title cisco-nxos-provider: configure ISIS cisco-nxos-provider: add ISIS configuration Aug 15, 2025
Copy link
Contributor

@felix-kaestner felix-kaestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some nits about comments. Nothing blocking a merge from my perspective. :)

Copy link
Contributor

@felix-kaestner felix-kaestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikatza Pls squash all commits when merging, so we don't end up with "PR comments" commits in the history.

Configure ISIS on a NXOS device allowing the parametrization of: 1) the
instance name, 2) the Network Entitity Title, 3) the type ("Level1",
"Level2", and "Level12"), 4) the number of seconds of the on-startup
overload bit, and 5) two address families: IPv4 and IPv6 unicast. With
this package we support the minimum configuration required to build the
underlay as in this example:

```
router isis UNDERLAY
  net 49.0001.0001.0000.0001.00
  is-type level-1
  set-overload-bit on-startup 61
  address-family ipv4 unicast
  address-family ipv6 unicast
```
@nikatza nikatza merged commit 76cc0c8 into main Aug 19, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this to Done in Roadmap Aug 19, 2025
@nikatza nikatza deleted the feat-add-igp branch August 19, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metal-automation Automation processes within the Metal project.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants